fix(rocm): avoid indirect host pointers during HIP graph capture - #316
Open
ErikBPF wants to merge 1 commit into
Open
fix(rocm): avoid indirect host pointers during HIP graph capture#316ErikBPF wants to merge 1 commit into
ErikBPF wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ROCm graph capture can fault when the fused multi-bank expert copy reads pinned-host source addresses indirectly through a device pointer table. During HIP capture only, use the existing per-bank copy path whose source is a direct tensor argument.
Reproducer and evidence
Validated on Orion ROCm
gfx1201with realistic Qwen expert-row geometry:The historical endpoint throughput varied between runs, so this PR claims graph correctness, not a speedup.
Tests
Packaging validation: Python compile, Ruff on the changed test, and
git diff --checkpass.Scope and overlap
Two files only. This complements #260, whose MVP intentionally disables HIP graph capture, and does not duplicate its ROCm bring-up changes. Qwen model support, FTW changes, tuning, and local research docs are excluded.